Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): add space.updateSpaceMembers() method #2603

Merged
merged 17 commits into from
Mar 7, 2024
Merged

feat(rest-api-client): add space.updateSpaceMembers() method #2603

merged 17 commits into from
Mar 7, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • Support updateSpaceMembers method to be able to update the members of a Space.

What

  • Add new method updateSpaceMembers
  • Add unit test
  • Add demo script

How to test

  • Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and tasshi-me and removed request for a team March 4, 2024 03:04
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Mar 4, 2024
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
@tuanphamcybozu tuanphamcybozu removed the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
@tuanphamcybozu tuanphamcybozu removed the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
renovate bot and others added 2 commits March 5, 2024 19:44
@renovate @tuanphamcybozu
chore(deps): update dependency vite to ^5.1.5 (#2604)
281a4ab 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tuanphamcybozu @hung-cybo
feat(rest-api-client): add space.updateSpaceBody() method (#2598)
8ab8de6 
Co-authored-by: hung-cybo <hung-nguyen@cybozu.vn>
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
@tuanphamcybozu tuanphamcybozu removed the pkg: create-plugin @kintone/create-plugin label Mar 5, 2024
hung-cybo
hung-cybo approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tasshi-me
tasshi-me approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 5b28413 into master Mar 7, 2024
10 checks passed
@tasshi-me tasshi-me deleted the feat/add-updateSpaceMembers-method branch March 7, 2024 10:19
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuanphamcybozu @tasshi-me @hung-cybo