Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): add space.addGuests() method #2622

Merged
merged 16 commits into from
Mar 19, 2024

Conversation

hung-cybo
Copy link
Contributor

Why

  • Support addGuests method to be able to add guest users to Kintone.

What

  • Add new method addGuests
  • Add unit test
  • Add demo script

How to test

  • Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and tasshi-me and removed request for a team March 13, 2024 12:56
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Mar 13, 2024
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pkg: plugin-uploader @kintone/plugin-uploader label Mar 14, 2024
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label Mar 15, 2024
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	examples/rest-api-client-demo/src/space.ts
#	packages/rest-api-client/docs/space.md
#	packages/rest-api-client/src/client/SpaceClient.ts
#	packages/rest-api-client/src/client/__tests__/SpaceClient.test.ts
#	packages/rest-api-client/src/client/types/space/index.ts
@hung-cybo hung-cybo merged commit 210f2c4 into master Mar 19, 2024
10 checks passed
@hung-cybo hung-cybo deleted the feat/add-addGuests-method branch March 19, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-plugin @kintone/create-plugin pkg: plugin-uploader @kintone/plugin-uploader pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants