Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-uploader): support new Kintone UI #2711

Merged
merged 14 commits into from
May 8, 2024
Merged

feat(plugin-uploader): support new Kintone UI #2711

merged 14 commits into from
May 8, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • plugin-uploader support the new kintone UI

What

  • reactor code to support old and new UI

How to test

  • plugin-uploader works on old and new UI correctly.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and minh-nguyen1985 and removed request for a team April 17, 2024 09:23
@github-actions github-actions bot added the pkg: plugin-uploader @kintone/plugin-uploader label Apr 17, 2024
@aws-amplify-ap-northeast-1 AWS Amplify (ap-northeast-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2711.d1ite8zvzg8c5i.amplifyapp.com

tasshi-me
tasshi-me requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some requests for changes!

packages/plugin-uploader/src/index.ts Outdated Show resolved Hide resolved
packages/plugin-uploader/src/pages/PluginSystemPageBase.ts Outdated Show resolved Hide resolved
packages/plugin-uploader/src/messages.ts Outdated Show resolved Hide resolved
packages/plugin-uploader/src/pages/OldPluginSystemPage.ts Outdated Show resolved Hide resolved
@tasshi-me tasshi-me changed the title feat(plugin-uploader): support new Kintone UI (react) feat(plugin-uploader): support new Kintone UI Apr 24, 2024
tasshi-me
tasshi-me approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

renovate bot and others added 12 commits May 8, 2024 10:28
@renovate @tuanphamcybozu
chore(deps): update dependency typescript to ^5.4.5 (#2697)
1d5d255 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
chore(deps): update dependency @types/eslint to ^8.56.8 (#2698)
f8c8546 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
chore(deps): update dependency @types/eslint to ^8.56.9 (#2701)
43a2cad 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
chore(deps): update dependency rollup to ^4.14.2 (#2702)
dea902d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
fix(deps): update dependency qs to ^6.12.1 (#2703)
b188d17 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
chore(deps): update pnpm to v8.15.7 (#2704)
c42b974 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @tuanphamcybozu
chore(deps): update dependency rollup to ^4.14.3 (#2705)
e8f9d48 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tuanphamcybozu
feat: modify TIMEOUT_MS for new ui
f2906a9
@tuanphamcybozu
test(webpack-plugin-kintone-plugin): fix failed test on windows (#2718)
941c1ae
@hung-cybo @tuanphamcybozu
refactor: audit code
1d3afae
@hung-cybo @tuanphamcybozu
refactor: convert to PluginSystemController
f8405a1
@hung-cybo @tuanphamcybozu
fix: no administrator privileges
b875af3
@github-actions github-actions bot added pkg: rest-api-client @kintone/rest-api-client pkg: dts-gen @kintone/dts-gen pkg: create-plugin @kintone/create-plugin pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin labels May 8, 2024
@tasshi-me tasshi-me merged commit ca6ca58 into master May 8, 2024
18 checks passed
@tasshi-me tasshi-me deleted the feat/support-new-kintone-ui branch May 8, 2024 04:00
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@minh-nguyen1985 minh-nguyen1985 Awaiting requested review from minh-nguyen1985

Assignees
No one assigned
Labels
pkg: create-plugin @kintone/create-plugin pkg: dts-gen @kintone/dts-gen pkg: plugin-uploader @kintone/plugin-uploader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuanphamcybozu @tasshi-me @hung-cybo