Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): add app.moveToSpace method #2855

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

shabaraba
Copy link
Member

Why

Support app.moveToSpace method to be able to changes the Space to which an App belongs.

What

  • Add new methods, app.moveToSpace
  • Add unit test
    • When I run pnpm fix, I faced the warning as below in AppClientTest:
      Arrow function has too many statements (41). Maximum allowed is 40 max-statements
      So I implemented the new unit tests separately from the existing root description method.
  • Add demo script
  • Add doc

How to test

Check test spec.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 2, 2024
@shabaraba shabaraba marked this pull request as ready for review July 2, 2024 07:44
@shabaraba shabaraba requested a review from tasshi-me July 2, 2024 23:38
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a nitpick comment.

packages/rest-api-client/docs/app.md Outdated Show resolved Hide resolved
@shabaraba shabaraba force-pushed the feat/add-app-move-to-space-method branch from 32b9073 to d58f065 Compare July 9, 2024 06:24
@shabaraba shabaraba requested a review from tasshi-me July 9, 2024 06:55
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shabaraba shabaraba force-pushed the feat/add-app-move-to-space-method branch from 25ccd6d to b1fbeb9 Compare July 10, 2024 03:07
@tasshi-me tasshi-me merged commit be0e5a4 into main Jul 10, 2024
17 checks passed
@tasshi-me tasshi-me deleted the feat/add-app-move-to-space-method branch July 10, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants