Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): add the method of app.addPlugins #2910

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 30, 2024

Why

  • Support app.addPlugins method to be able to add Plug-ins to an App.

What

  • Add a document for the new methods.
  • Add new unit tests.

How to test

  1. prepare installed plug-ins and apps in Kintone.
  2. run below code and check logs:
import {KintoneRestAPIClient} from '@kintone/rest-api-client';

const client = new KintoneRestAPIClient();

const pluginId = (await client.app.getPlugins({app: 1})).plugins[0].id;

console.log(await client.app.getPlugins({app: 2, preview: true}));
console.log(await client.app.addPlugins({app: 2, ids: [pluginId]}));
console.log(await client.app.getPlugins({app: 2, preview: true}));

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 30, 2024
@shabaraba shabaraba force-pushed the feat/add-method-app-addPlugins branch from 90642de to 1eb54fb Compare July 30, 2024 04:30
@shabaraba shabaraba marked this pull request as ready for review July 30, 2024 04:37
@shabaraba shabaraba requested a review from tasshi-me July 30, 2024 04:38
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shabaraba shabaraba changed the title feat(rest-api-client): add docs for the method of app.addPlugins feat(rest-api-client): add the method of app.addPlugins Jul 30, 2024
@hisasami hisasami merged commit 37c3a45 into main Jul 31, 2024
17 checks passed
@hisasami hisasami deleted the feat/add-method-app-addPlugins branch July 31, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants