Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dts-gen): Fix to not read eslint.config #3066

Merged

Conversation

tuchida
Copy link
Contributor

@tuchida tuchida commented Nov 14, 2024

ref. #3059

Why

I installed and ran the package and got an error Error: Could not find config file..

What

I fixed to not read eslint.config, when using ESLint in running dts-gen,

How to test

js-sdk/packages/dts-gen$ pnpm build
js-sdk/packages/dts-gen$ rm eslint.config.mjs
js-sdk/packages/dts-gen$ rm ../../eslint.config.mjs
js-sdk/packages/dts-gen$ ls fields.d.ts 
ls: 'fields.d.ts' にアクセスできません: そのようなファイルやディレクトリはありません
js-sdk/packages/dts-gen$ direnv exec . node dist/index.js --app-id 4 --type-name App顧客リストFields
js-sdk/packages/dts-gen$ ls fields.d.ts 
fields.d.ts

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuchida tuchida requested a review from a team as a code owner November 14, 2024 01:36
@tuchida tuchida requested review from chihiro-adachi and tasshi-me and removed request for a team November 14, 2024 01:36
@github-actions github-actions bot added the pkg: dts-gen @kintone/dts-gen label Nov 14, 2024
@chihiro-adachi
Copy link
Contributor

手順通り動作することを確認しました。

$ pnpm build
$ rm eslint.config.mjs
$ rm ../../eslint.config.mjs
$ node dist/index.js --app-id 1 --type-name 'App取引先Fields' --base-url=http://localhost --username=Administrator --password=cybozu
$ ls fields.d.ts 
fields.d.ts

@chihiro-adachi chihiro-adachi merged commit 4f0048f into kintone:main Nov 14, 2024
18 checks passed
@chihiro-adachi
Copy link
Contributor

@tuchida
Thank you. merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: dts-gen @kintone/dts-gen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants