Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Add back the external_url in the prometheus block #826

Closed
surajssd opened this issue Aug 21, 2020 · 2 comments · Fixed by #964
Closed

Add back the external_url in the prometheus block #826

surajssd opened this issue Aug 21, 2020 · 2 comments · Fixed by #964
Assignees
Labels
area/components Items related to components area/monitoring Monitoring priority/P1 High priority
Milestone

Comments

@surajssd
Copy link
Member

Remove this overriding of the ingress.host as it is done here:

{{ if .Prometheus.Ingress }}
externalUrl: https://{{.Prometheus.Ingress.Host}}
{{ end }}

Add back the dedicated external_url to the prometheus block, like it is done for the alertmanager.

@surajssd surajssd added area/components Items related to components area/monitoring Monitoring proposed/next-sprint Issues proposed for next sprint labels Aug 21, 2020
@surajssd surajssd changed the title Add external_url in the prometheus block Add back the external_url in the prometheus block Aug 21, 2020
@surajssd surajssd self-assigned this Aug 21, 2020
@surajssd surajssd added the priority/P1 High priority label Sep 2, 2020
@iaguis iaguis removed the proposed/next-sprint Issues proposed for next sprint label Sep 3, 2020
@johananl
Copy link
Member

@surajssd can this be closed before the next sprint?

@surajssd
Copy link
Member Author

@johananl yep the PR is open, PTAL #964

@iaguis iaguis added this to the v0.5.0 milestone Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/components Items related to components area/monitoring Monitoring priority/P1 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants