Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Bad performance - Url Tracker #120

Closed
jacktinuss opened this issue Mar 10, 2016 · 10 comments
Closed

Bad performance - Url Tracker #120

jacktinuss opened this issue Mar 10, 2016 · 10 comments

Comments

@jacktinuss
Copy link

Hi there!

We are experiencing some huge performance issues on a customer running Umbraco v.6.1.6 and Url Tracker v.3.8

When Url Tracker is enabled - the request times for every resource are very long compared to the same request times when the Url Tracker is disabled (setting urlTracker:disabled to true in web.config).

A few examples:

xyz.local/CropUp/topimage/media/49174/picture.JPG: Url Tracker enabled : 209 ms - Url Tracker disabled : 5 ms

jquery.flexslider.js: Url Tracker enabled : 278 ms - Url Tracker disabled : 22 ms

ga-event-tracking.js: Url Tracker enabled : 640 ms - Url Tracker disabled : 41 ms

All in all this means that for normal page, the total load time with Url Tracker Enabled is: 1,75 seconds - and with Url Tracker disabled it is: 0,49 seconds.

We have tried emptying the icUrlTracker table and also made sure that the cache is cleared when testing. It doesn't help. We have also tried updating to the newest Url Tracker version without any luck.

Do you know what the problem can be?

It is really making the overall experience of the website very bad.

Thanks in advance!

@martinabrahams
Copy link

Hi @jacktinuss I have experienced the same issue. We ran a memory profile and found the following change to have a massive impact, it went from being catastrophically bad to ok.

In our scenario the site uses multiple domains, if you're not using domains it might not have any impact. I've put a pull request in for this, you can see the change

#105 commit aa38351

@jacktinuss
Copy link
Author

Wow!

That seemed to do the trick!

Loadtime on random page has gone from 1,6 seconds to 0,4 seconds.

Loadtime of random image has gone from 270 ms to 7 ms.
Thanks!

@kipusoep
Copy link
Owner

Thanks for reporting and fixing this. I wasn't able to look at it this week and won't be until week 12.
But I'll merge the PR asap.

@jacktinuss
Copy link
Author

Thanks!

Should it be safe for me to take newest commit on the master branch and include martinabrahams changes and deploy the dll to the production environment? I mean, should i do anything regarding the DB tables or anything else?

The production environment is currently running 3.8. - i guess the new version will be 3.11.something?

@kipusoep
Copy link
Owner

It will be 3.12 and what you're suggesting is safe as far as I can tell.

@martinabrahams
Copy link

@jacktinuss you're welcome.

@protherj
Copy link

Any chance you will be releasing an update for 3.12 this week?

@kipusoep
Copy link
Owner

No sorry, I'm unable to maintain this project at the moment. I need some contributers I guess...

@protherj
Copy link

How can we help with the package build? Are there instructions or a batch process to run?

@kipusoep
Copy link
Owner

No instructions, just a VS solution, Github source control and a NuGet package.

@ghost ghost mentioned this issue Jun 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants