Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Cache node_modules in GitHub Actions to speed up builds #1360

Closed
4 of 5 tasks
jakobe opened this issue Feb 25, 2021 · 1 comment · Fixed by #1494
Closed
4 of 5 tasks

[Housekeeping] Cache node_modules in GitHub Actions to speed up builds #1360

jakobe opened this issue Feb 25, 2021 · 1 comment · Fixed by #1494

Comments

@jakobe
Copy link
Collaborator

jakobe commented Feb 25, 2021

Short description of housekeeping request
We would like to cache node_modules in our GitHub Actions to speed up the rpm install step.

Alternatives
Waiting and drinking ☕

Additional context
See: https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows

Tasks

Kick Off

  • Ensure this issue has been Tech refined with @kirbydesign/kirby-guild and is updated with a clear implementation description
    This issue should be in the Ready to do column of the Kirby kan-ban board before starting implementation
  • Assign yourself to this issue and move it to the In progress column of the Kirby kan-ban board

Code

  • Create Feature Branch from master branch
  • Implement/update unit tests
  • Create a draft implementation and push to Github
  • Ask a member of @kirbydesign/kirby-guild for a WIP review by creating a draft Pull Request

Code Review

  • Open a pull request (or mark the existing draft PR as Ready for review) and ask @kirbydesign/kirby-guild for a review
    Remember to add closes #issueno to the description of the PR.
  • Once approved, merge feature branch/PR to master

🎉 Celebrate

@jakobe jakobe added this to the Productifying milestone Feb 25, 2021
@MadsBuchmann MadsBuchmann self-assigned this Mar 5, 2021
@MadsBuchmann
Copy link
Contributor

MadsBuchmann commented Mar 5, 2021

Unassigned myself as a blocked issue I was assigned to on was just unblocked.

@MadsBuchmann MadsBuchmann removed their assignment Mar 5, 2021
@MadsBuchmann MadsBuchmann self-assigned this Apr 22, 2021
@alxzak alxzak modified the milestones: Productifying, Masterplanning 8 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants