Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Replace "more" icon #2173

Closed
1 of 11 tasks
henrikvoetmand opened this issue Apr 20, 2022 · 0 comments · Fixed by #2176
Closed
1 of 11 tasks

[Enhancement] Replace "more" icon #2173

henrikvoetmand opened this issue Apr 20, 2022 · 0 comments · Fixed by #2176

Comments

@henrikvoetmand
Copy link
Collaborator

Describe the enhancement

The "more" icon is not the same as in the design files. (Sketch & Zeplin)

Skærmbillede 2022-04-20 kl  13 01 02

Describe the solution you'd like

Replace the old "more" icon svg file in Kirby with the new svg file (attached to this issue)

Have you considered any alternatives?

Are there any additional context?

New svg file:
more


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the stable branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request component:Icon NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Apr 20, 2022
@henrikvoetmand henrikvoetmand changed the title [Enhancement] [Enhancement] Replace "more" icon Apr 20, 2022
@MadsBuchmann MadsBuchmann mentioned this issue Apr 21, 2022
7 tasks
@MadsBuchmann MadsBuchmann moved this to 🔎 Review pending in Kirby Apr 21, 2022
Repository owner moved this from 🔎 Review pending to ✅ Done in Kirby Apr 21, 2022
@MadsBuchmann MadsBuchmann added 🟢 Ready for release and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants