Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] A11y improvements for Modal #3677

Closed
3 of 13 tasks
jakobe opened this issue Oct 22, 2024 · 0 comments · Fixed by #3702
Closed
3 of 13 tasks

[Enhancement] A11y improvements for Modal #3677

jakobe opened this issue Oct 22, 2024 · 0 comments · Fixed by #3702
Assignees
Labels
accessibility enhancement New feature or request

Comments

@jakobe
Copy link
Collaborator

jakobe commented Oct 22, 2024

Describe the enhancement

The following tasks should be completed to improve the a11y of the Modal component:

  • Ensure modal is labelled with a title
    • This can be achieved by associating ion-title of modal-wrapper.component.html to ion-modal through aria-labelledby. This could be set on the ionModalElement instance in ModalWrapperComponent.ngOnInit.
      Please note: ion-title will need a unique id.
      More info: https://ionicframework.com/docs/api/modal#labels
  • Ensure the close button is labelled with a title

Describe the solution you'd like

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@jakobe jakobe added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Oct 22, 2024
@github-project-automation github-project-automation bot moved this to 📙 Backlog in Kirby Oct 22, 2024
@jakobe jakobe added accessibility and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels Oct 22, 2024
@alxzak alxzak removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Oct 23, 2024
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Oct 31, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 🔎 Review pending in Kirby Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 Review In Progress to ✅ Done in Kirby Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants