Avatar: support lazy loading of image #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzy3
previously requested changes
Nov 28, 2024
| @@ -27,6 +27,7 @@ export enum AvatarSize { | |||
| }) | |||
| export class AvatarComponent { | |||
| @Input() imageSrc: string; | |||
| @Input() imageLoading: 'eager' | 'lazy' | undefined; | |||
There was a problem hiding this comment.
Any reason for having 'undefined' as type since undefined results in the default value which is 'eager'?
There was a problem hiding this comment.
Could potentially just have 'eager' as default value
There was a problem hiding this comment.
The reason is we don't set the html attribute if the input property is not set. That will then default to the browser's default (which is eager), but IMO we shouldn't "own" that fallback, the browser should :)
RasmusKjeldgaard
approved these changes
Nov 29, 2024
RasmusKjeldgaard
dismissed
Fuzzy3’s stale review
Requested change was actually a comment
…zy-loading-of-image
jakobe
deleted the
enhancement/3726-avatar-should-support-lazy-loading-of-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3726
What is the new behavior?
Adds support for lazy loading of the image in image avatars.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.