Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BGRA conversion optional #2

Open
merlindru opened this issue Dec 29, 2022 · 2 comments
Open

Make BGRA conversion optional #2

merlindru opened this issue Dec 29, 2022 · 2 comments

Comments

@merlindru
Copy link

When encoding with e.g. ffmpeg, ffmpeg can handle the conversion, right? It'd be great if we could disable the conversion to RGBA.

Maybe it'd make sense to remove it from the library completely, because if someone wants to convert BGRA -> RGBA, it's just one line to add?

Just throwing around a couple ideas :)

Many thanks for building this lib!

@kirides
Copy link
Owner

kirides commented Feb 14, 2023

i just remembered that BGRA<->RGBA is done automatically on "modern" Windows, if IDXGIOutput5::DuplicateOutput1 is used with the requested image format.

i'd like to close this issue, as most shouldn't need to worry about this.

@kirides
Copy link
Owner

kirides commented Feb 23, 2023

with microsoft deprecating more and more windows versions, i might not even go so far to disable the BGRA conversion, but rather allow the consumer to specify their own compatible format to let windows do the work (or non)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants