Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite onTextChanged to onSelectionChanged event handler in KeyboardAwareScrollView #546

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kirillzyusko
Copy link
Owner

To Do

  • looks like useAnimatedReaction on iOS doesn't work (FirstInputGrown image has changed);
  • Android - when scroll back disabled it still scrolls πŸ€·β€β™‚οΈ
  • Android - when we type 1 we still have the same image as before - theoretically padding should be reduced.

πŸ“œ Description

πŸ’‘ Motivation and Context

Closes #512

πŸ“’ Changelog

JS

iOS

Android

πŸ€” How Has This Been Tested?

πŸ“Έ Screenshots (if appropriate):

πŸ“ Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added πŸ› bug Something isn't working KeyboardAwareScrollView πŸ“œ Anything related to KeyboardAwareScrollView component labels Aug 12, 2024
@kirillzyusko kirillzyusko self-assigned this Aug 12, 2024
Copy link
Contributor

πŸ“Š Package size report

Current size Target Size Difference
149903 bytes 149599 bytes 304 bytes πŸ“ˆ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working KeyboardAwareScrollView πŸ“œ Anything related to KeyboardAwareScrollView component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting an entire line in a long text inside an input makes scroll to the top on iOS
1 participant