Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide OpenSSL headers in private module #20

Merged
merged 2 commits into from
Feb 10, 2018
Merged

Hide OpenSSL headers in private module #20

merged 2 commits into from
Feb 10, 2018

Conversation

kishikawakatsumi
Copy link
Contributor

@kishikawakatsumi kishikawakatsumi commented Feb 8, 2018

Fixes #3
Fixes #17

No longer needed to add header search paths in a user project.

@kishikawakatsumi kishikawakatsumi force-pushed the openssl branch 2 times, most recently from 767625d to 33521ba Compare February 9, 2018 15:54
@codecov
Copy link

codecov bot commented Feb 10, 2018

Codecov Report

Merging #20 into master will decrease coverage by 0.13%.
The diff coverage is 72.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   50.16%   50.03%   -0.14%     
==========================================
  Files          23       24       +1     
  Lines        3026     2984      -42     
  Branches       41       45       +4     
==========================================
- Hits         1518     1493      -25     
+ Misses       1508     1491      -17
Impacted Files Coverage Δ
BitcoinKit/HDPublicKey.swift 34.54% <0%> (+15.73%) ⬆️
BitcoinKit/Mnemonic.swift 63.46% <100%> (-3.21%) ⬇️
BitcoinKit/Serialization.swift 46.96% <100%> (ø) ⬆️
BitcoinKit/Crypto.swift 100% <100%> (ø) ⬆️
BitcoinKit/PrivateKey.swift 83.95% <100%> (-1.77%) ⬇️
BitcoinKit/PublicKey.swift 85.71% <100%> (-7.62%) ⬇️
BitcoinKit/BitcoinKitInternal.m 71.42% <71.42%> (ø)
BitcoinKit/HDPrivateKey.swift 92.59% <90.9%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5442608...5d233ec. Read the comment docs.

@kishikawakatsumi kishikawakatsumi merged commit 7ee3eda into master Feb 10, 2018
@kishikawakatsumi kishikawakatsumi deleted the openssl branch February 10, 2018 09:40
johndpope pushed a commit to johndpope/BitcoinKit that referenced this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant