Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can/should we get rid of zope_interface's fix-init patch ? #3083

Open
Cheaterman opened this issue Nov 16, 2024 · 1 comment
Open

Can/should we get rid of zope_interface's fix-init patch ? #3083

Cheaterman opened this issue Nov 16, 2024 · 1 comment

Comments

@Cheaterman
Copy link
Contributor

Cheaterman commented Nov 16, 2024

# this is solved in the future an error will be triggered

If you check on Kivy Discord (or even in buildozer issues: kivy/buildozer#1601), there's a few mentions (including mine) of twisted failing to build because of zope_interface. It seems to work properly if we remove the fix-init patch, so maybe we're indeed in the future (cf comment in the recipe) and this errors out?

I opened this issue (instead of directly making a PR) to discuss the situation, in particular to check if people manage to properly build projects that use twisted without issues, in which case maybe the fix-init patch isn't the root cause.

@AndreMiras
Copy link
Member

Thanks for the report.
I would say if it doesn't even build and fail at patching with zope interface, I don't see why not removing it indeed.
In the worst case it fails runtime, but it's still some steps further.
So yeah feel free to come up with a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants