Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Icon.Content and replace it with ViewBuilder parameters #525

Closed
PavelHolec opened this issue Apr 5, 2023 · 0 comments · Fixed by #597
Closed

Remove Icon.Content and replace it with ViewBuilder parameters #525

PavelHolec opened this issue Apr 5, 2023 · 0 comments · Fixed by #597
Assignees
@PavelHolec
Labels
enhancement New feature or request
Milestone
2023Q2

Comments

@PavelHolec
Copy link
Collaborator

PavelHolec commented Apr 5, 2023 •
edited
Loading

To allow more flexible customization of components that include icons, we can simplify the icon usage by removing the Icon.Content wrapping type by inits accepting ViewBuilder closures.
@PavelHolec PavelHolec added the enhancement New feature or request label Apr 5, 2023
@PavelHolec PavelHolec added this to the 2023Q2 milestone Apr 5, 2023
@PavelHolec PavelHolec self-assigned this Apr 5, 2023
@PavelHolec PavelHolec changed the title Remove Icon.Content and replace it with ViewBuilder parameters Remove Icon.Content and replace it with Icon parameter Apr 12, 2023
@PavelHolec PavelHolec mentioned this issue Jun 14, 2023
Closed
@PavelHolec PavelHolec linked a pull request Jun 15, 2023 that will close this issue
Remove Icon.Content and replace it with ViewBuilder parameters #597
Merged
@PavelHolec PavelHolec reopened this Jun 19, 2023
@PavelHolec PavelHolec changed the title Remove Icon.Content and replace it with Icon parameter Remove Icon.Content and replace it with ViewBuilder parameters Jun 19, 2023
@sjavora sjavora mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PavelHolec PavelHolec

Labels
enhancement New feature or request
Projects
None yet
Milestone
2023Q2
Development

Successfully merging a pull request may close this issue.

Remove Icon.Content and replace it with ViewBuilder parameters kiwicom/orbit-swiftui
1 participant
@PavelHolec