Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextLinks disappear when app resigns active #853

Closed
sjavora opened this issue Nov 11, 2024 · 1 comment · Fixed by #856
Closed

TextLinks disappear when app resigns active #853

sjavora opened this issue Nov 11, 2024 · 1 comment · Fixed by #856
Assignees
@PavelHolec
Labels
bug Something isn't working

Comments

@sjavora
Copy link
Member

sjavora commented Nov 11, 2024

This is due to redactionReasons getting set to .privacy by iOS.

I doubt we want to actually set the text color to .clear in this case. It looks bad in the app and the native link support in SwftIUI.Text doesn't do it. Compare Orbit Text (top, green) with SwiftUI Text (bottom, red).

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-11.at.08.08.44.mp4
@sjavora sjavora added the bug Something isn't working label Nov 11, 2024
@PavelHolec PavelHolec self-assigned this Nov 11, 2024
@PavelHolec
Copy link
Collaborator

Side effect of #788

@PavelHolec PavelHolec linked a pull request Nov 13, 2024 that will close this issue
Only hide text values on .placeholder redaction reason #856
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PavelHolec PavelHolec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only hide text values on .placeholder redaction reason kiwicom/orbit-swiftui
2 participants
@sjavora @PavelHolec