Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add a flag to declare model timestamps as not nullable #84

Open
joelstein opened this issue Nov 5, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@joelstein
Copy link

What happened?

First of all, thanks for this excellent package. Also, I couldn't figure out how to request a feature, so this is coming through as a bug report. Sorry!

Laravel's model timestamps always makes created_at and updated_at nullable (here's why).

This causes the types to be like:

created_at?: string
updated_at?: string

Even though they will always have a value.

Would you consider adding a config option to force model timestamps always to be strings instead of nullable strings?

How to reproduce the bug

(The bug report form requires me to put something here...)

Package Version

3.1

PHP Version

8.3.13

Which operating systems does with happen with?

macOS

Notes

No response

@joelstein joelstein added the bug Something isn't working label Nov 5, 2024
@ewilan-riviere ewilan-riviere added enhancement New feature or request and removed bug Something isn't working labels Nov 5, 2024
@ewilan-riviere ewilan-riviere self-assigned this Nov 5, 2024
@ewilan-riviere
Copy link
Contributor

Thanks!

It's a very good idea! I will work on it in this week ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants