From 355bdecbb4ad7e2c1573e4c40ec5018e2cbdc925 Mon Sep 17 00:00:00 2001
From: dswan36 <damian.swan@st.gactc.edu>
Date: Thu, 5 Sep 2024 13:19:16 +0000
Subject: [PATCH 1/4] Patch link to 11 to now reflect 301

---
 docs/tools/filecreator.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/tools/filecreator.html b/docs/tools/filecreator.html
index 762c3ae6..eb5a9943 100644
--- a/docs/tools/filecreator.html
+++ b/docs/tools/filecreator.html
@@ -19,14 +19,14 @@ <h1>Onc Creator</h1><br>
 
   gtag('config', 'G-009HP51NPG');
 </script>
-<p>Check out <a href="/11.html">#11</a> for details on how to use this creator (Getting your OpenVPN Credentials, Server Hosts, etc)</p><br>
-<p>Hover over a specific field to get some brief info on it! Any links will take you to the relivant page to get you in the know.</p><br>
+<p>Check out <a href="/discussions/301.html">#11</a> for details on getting started!</p><br>
+<p>Hover over a specific field to get some brief info on it! If clickable, underlined text will take you to a helpful page.</p><br>
 <body>File Name
    <input title="You can name this anything!!" value="Silly Little Clone" placeholder="Config Name" id ="nametype"></input><br>
    <a href="/tools/directory/serverlister.html" target="_blank">Host Name</a><input title="The IP address to connect to" value="89.39.107.188" placeholder="Host Server" id ="hostname"></input><br>
    <a href="/tools/directory/serverlister.html" target="_blank">Host Port</a><input type=number value="51820" title="What port to connect to, default should be good if you don't know" placeholder="Host Port" id="hostport"></input><br>
-   <a href="/discussions/11.html" target="_blank">User Name</a><input title="Your Username to authenticate!" type=text value="ih1M47aG67vpkrph" placeholder="Username" id ="username"></input><br>
-   <a href="/discussions/11.html" target="_blank">Pass Key</a><input title="Your password to authenticate!" type=text value="lqhscAT04QLKPiK5sDtSTKaaIyQexkDW" placeholder="Password" id="password"></input><br>
+   <a href="/discussions/301.html" target="_blank">User Name</a><input title="Your Username to authenticate!" type=text value="ih1M47aG67vpkrph" placeholder="Username" id ="username"></input><br>
+   <a href="/discussions/301.html" target="_blank">Pass Key</a><input title="Your password to authenticate!" type=text value="lqhscAT04QLKPiK5sDtSTKaaIyQexkDW" placeholder="Password" id="password"></input><br>
     <textarea title="This is where the data you put in above will go!" id="inputBox" rows="4" cols="50" disabled>{
 "Type": "UnencryptedConfiguration",
 "Certificates": [

From 705b9656ba186f34920d1d3e655a23b05c615b0e Mon Sep 17 00:00:00 2001
From: dswan36 <damian.swan@st.gactc.edu>
Date: Thu, 5 Sep 2024 13:33:15 +0000
Subject: [PATCH 2/4] (JS-0246) : Require template literals instead of string
 concatenation

https://github.com/dswan36/SillyLittleFiles/issues/355

Signed-off-by: dswan36 <damian.swan@st.gactc.edu>
---
 docs/tools/filecreator.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/docs/tools/filecreator.js b/docs/tools/filecreator.js
index 3e8dd4a4..48f33bca 100644
--- a/docs/tools/filecreator.js
+++ b/docs/tools/filecreator.js
@@ -11,17 +11,17 @@ function submit () {
   document.getElementById('username').disabled = true
   document.getElementById('password').disabled = true
   let text = inputBox.value
-  text = text.replace('"Name": "NME"', '"Name": "' + nametype + '"')
-  text = text.replace('"Host": "HST"', '"Host": "' + hostname + '"')
-  text = text.replace('"Port": "PRT"', '"Port": ' + hostport)
-  text = text.replace('"Username": "USNM"', '"Username": "' + username + '"')
-  text = text.replace('"Password": "PASSD"', '"Password": "' + password + '"')
+  text = text.replace('"Name": "NME"', `"Name": "${nametype}"`)
+  text = text.replace('"Host": "HST"', `"Host": "${hostname}"`)
+  text = text.replace('"Port": "PRT"', `"Port": ${hostport}`)
+  text = text.replace('"Username": "USNM"', `"Username": "${username}"`)
+  text = text.replace('"Password": "PASSD"', `"Password": "${password}"`)
   inputBox.value = text // Inject data into inputbox
   const ftext = document.getElementById('inputBox').value // And now a new variable to prevent duplacated declarations
   const element = document.createElement('a')
   element.setAttribute(
     'href',
-    'data:text/plain;charset=utf-8,' + encodeURIComponent(ftext) // Inject that var into the onc text/plain format
+    `data:text/plain;charset=utf-8, ${encodeURIComponent(ftext)}` // Inject that var into the onc text/plain format
   )
   async function fetchRandomWord () {
     try {
@@ -30,10 +30,10 @@ function submit () {
       )
       const data = await response.json()
 
-      const filename = data + '.onc' // Set the page title to the random word
+      const filename = `${data}.onc` // Set the page title to the random word
       return filename
     } catch (error) {
-      console.error('Error fetching in fetchRandomWord:', error)
+      console.error(`Error fetching in fetchRandomWord: ${error}`)
       const filename = 'pop.onc' // Fallback to default file name if error
       return filename
     }
@@ -41,15 +41,15 @@ function submit () {
   async function downloadFile () {
     try {
       const filename = await fetchRandomWord()
-      element.setAttribute('download', filename)
+      element.setAttribute(`download ${filename}`)
       element.style.display = 'none'
       document.body.appendChild(element)
       element.click()
       document.body.removeChild(element)
       window.location.reload()
-      alert('Your file has been delivered as: ' + filename)
+      alert(`Your file has been delivered as: ${filename}`)
     } catch (error) {
-      console.error('Error fetching word in downloadFile:', error)
+      console.error(`Error fetching word in downloadFile: ${error}`)
       element.setAttribute('download', 'pop.onc')
       element.style.display = 'none'
       document.body.appendChild(element)

From b40d2e0f4c07f711c5ceaafe9b285c0c7f1c6ce0 Mon Sep 17 00:00:00 2001
From: dswan36 <damian.swan@st.gactc.edu>
Date: Thu, 5 Sep 2024 14:03:08 +0000
Subject: [PATCH 3/4] JSD1001 @ FileCreator

https://app.deepsource.com/gh/dswan36/SillyLittleFiles/run/1dceffdc-807f-4897-93d8-8a78575dda7f/javascript/JS-D1001?listindex=3
---
 docs/tools/filecreator.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/tools/filecreator.js b/docs/tools/filecreator.js
index 48f33bca..9c032837 100644
--- a/docs/tools/filecreator.js
+++ b/docs/tools/filecreator.js
@@ -1,3 +1,4 @@
+// Collage all the data 
 function submit () {
   const nametype = document.getElementById('nametype').value
   const hostname = document.getElementById('hostname').value
@@ -23,6 +24,7 @@ function submit () {
     'href',
     `data:text/plain;charset=utf-8, ${encodeURIComponent(ftext)}` // Inject that var into the onc text/plain format
   )
+  // Fetch a random word and make it do things
   async function fetchRandomWord () {
     try {
       const response = await fetch(
@@ -38,6 +40,7 @@ function submit () {
       return filename
     }
   }
+  // LGTM, Download the file
   async function downloadFile () {
     try {
       const filename = await fetchRandomWord()

From 451315d4fdd75eeec941e184a0ede095ec580715 Mon Sep 17 00:00:00 2001
From: dswan36 <damian.swan@st.gactc.edu>
Date: Thu, 5 Sep 2024 14:06:39 +0000
Subject: [PATCH 4/4] (JS-D1001) : Documentation comments not found for
 functions and classes

Signed-off-by: dswan36 <damian.swan@st.gactc.edu>
---
 docs/tools/editjsn.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/tools/editjsn.js b/docs/tools/editjsn.js
index f87b381b..1a7b711f 100644
--- a/docs/tools/editjsn.js
+++ b/docs/tools/editjsn.js
@@ -1,3 +1,4 @@
+// Make the JSON pretty
 function beautifyJSON () {
   const jsonText = document.getElementById('jsonInput').value
   try {
@@ -8,7 +9,7 @@ function beautifyJSON () {
     document.getElementById('output').textContent = 'Error: Invalid JSON'
   }
 }
-
+// Make sure the JSON isnt crap
 function validateJSON () {
   const jsonText = document.getElementById('jsonInput').value
   try {
@@ -18,7 +19,7 @@ function validateJSON () {
     document.getElementById('output').textContent = 'Error: Invalid JSON'
   }
 }
-
+// Download the good JSON
 function downloadJSON () {
   const jsonText = document.getElementById('jsonInput').value
   const filename = 'out.json'
