From 3a9b03d062adbfd183cd9c110eaf023717040c5f Mon Sep 17 00:00:00 2001
From: Evan Lin <evan.if.lin@linecorp.com>
Date: Tue, 9 Jan 2024 01:45:49 +0800
Subject: [PATCH] refactor: refactor image link handling and add isImageLink
 function

- Simplify the image link handling by creating a separate function `isImageLink`
- Replace the multiple `switch` statements with a single `if-else` statement in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress`
- Add `.jpg` extension to image links from `https://imgur.com` in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress`
- Remove the unused `foundImage` variable in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress`
- Add the `isImageLink` function to check if a given URL is an image link

Signed-off-by: Evan Lin <evan.if.lin@linecorp.com>
---
 ptt.go | 66 +++++++++++++++++++---------------------------------------
 1 file changed, 21 insertions(+), 45 deletions(-)

diff --git a/ptt.go b/ptt.go
index 1ef3934..3d3f71a 100644
--- a/ptt.go
+++ b/ptt.go
@@ -53,21 +53,10 @@ func (p *PTT) GetAllFromURL(url string) (title string, allImages []string, like,
 	foundImage := false
 	doc.Find("a").Each(func(i int, s *goquery.Selection) {
 		imgLink, _ := s.Attr("href")
-		switch {
-		case strings.Contains(imgLink, "https://i.imgur.com/"):
-			allImages = append(allImages, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "http://i.imgur.com/"):
-			allImages = append(allImages, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://pbs.twimg.com/"):
-			allImages = append(allImages, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://imgur.com/"):
-			imgLink = imgLink + ".jpg"
-			allImages = append(allImages, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://i.meee.com.tw/"):
+		if isImageLink(imgLink) {
+			if strings.Contains(imgLink, "https://imgur.com/") {
+				imgLink = imgLink + ".jpg"
+			}
 			allImages = append(allImages, imgLink)
 			foundImage = true
 		}
@@ -145,21 +134,10 @@ func (p *PTT) Crawler(target string, workerNum int) {
 	foundImage := false
 	doc.Find("a").Each(func(i int, s *goquery.Selection) {
 		imgLink, _ := s.Attr("href")
-		switch {
-		case strings.Contains(imgLink, "https://i.imgur.com/"):
-			linkChan <- imgLink
-			foundImage = true
-		case strings.Contains(imgLink, "http://i.imgur.com/"):
-			linkChan <- imgLink
-			foundImage = true
-		case strings.Contains(imgLink, "https://pbs.twimg.com/"):
-			linkChan <- imgLink
-			foundImage = true
-		case strings.Contains(imgLink, "https://imgur.com/"):
-			imgLink = imgLink + ".jpg"
-			linkChan <- imgLink
-			foundImage = true
-		case strings.Contains(imgLink, "https://i.meee.com.tw/"):
+		if isImageLink(imgLink) {
+			if strings.Contains(imgLink, "https://imgur.com/") {
+				imgLink = imgLink + ".jpg"
+			}
 			linkChan <- imgLink
 			foundImage = true
 		}
@@ -188,21 +166,10 @@ func (p *PTT) GetAllImageAddress(target string) []string {
 	foundImage := false
 	doc.Find("a").Each(func(i int, s *goquery.Selection) {
 		imgLink, _ := s.Attr("href")
-		switch {
-		case strings.Contains(imgLink, "https://i.imgur.com/"):
-			ret = append(ret, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "http://i.imgur.com/"):
-			ret = append(ret, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://pbs.twimg.com/"):
-			ret = append(ret, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://imgur.com/"):
-			imgLink = imgLink + ".jpg"
-			ret = append(ret, imgLink)
-			foundImage = true
-		case strings.Contains(imgLink, "https://i.meee.com.tw/"):
+		if isImageLink(imgLink) {
+			if strings.Contains(imgLink, "https://imgur.com/") {
+				imgLink = imgLink + ".jpg"
+			}
 			ret = append(ret, imgLink)
 			foundImage = true
 		}
@@ -397,3 +364,12 @@ func CheckTitleWithBeauty(title string) bool {
 	d, _ := regexp.MatchString("^\\[正妹\\].*", title)
 	return d
 }
+
+// isImageLink checks if the given URL is an image link from supported hosts.
+func isImageLink(url string) bool {
+	return strings.Contains(url, "https://i.imgur.com/") ||
+		strings.Contains(url, "http://i.imgur.com/") ||
+		strings.Contains(url, "https://pbs.twimg.com/") ||
+		strings.Contains(url, "https://imgur.com/") ||
+		strings.Contains(url, "https://i.meee.com.tw/")
+}