Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files ( 'e' function ) #305

Closed
tonco-miyazawa opened this issue Jul 1, 2024 · 0 comments
Closed

Test files ( 'e' function ) #305

tonco-miyazawa opened this issue Jul 1, 2024 · 0 comments

Comments

@tonco-miyazawa
Copy link

This is a fix to make it "FAIL" when no error occurred.

The following four fixes:

if (r < ONIG_MISMATCH) {

if (r < ONIG_MISMATCH) {

if (r < ONIG_MISMATCH) {

if (r < ONIG_MISMATCH) {

Please rewrite it as follows.

//Before
if (r < ONIG_MISMATCH) {

//After
if (r < ONIG_MISMATCH || error_no < ONIG_MISMATCH) {

This will change the results of the following tests:

oniguruma/test/test_utf8.c

Lines 1651 to 1652 in ab444e0

e("(?Ii)$", "", ONIGERR_INVALID_GROUP_OPTION);
e("(?Ii)|", "", ONIGERR_INVALID_GROUP_OPTION);

and

  e("" , "" , -50000);
  e("a", "a", -50001);
  e("a", "b", -50002);

P.S. (*SKIP) worked fine. Thank you.

@kkos kkos closed this as completed in ec9d8c8 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant