Merge pull request #77 from Nevon/enable-basic-auth-in-webhooks

Allow setting webhook username and password
klarna · Mar 1, 2024 · e225a38 · e225a38
2 parents 841a653 + 20ede80
commit e225a38
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/sample_repo_configuration.yml b/sample_repo_configuration.yml
@@ -152,6 +152,7 @@ webhooks:
     active: true
     url: http://my_other_endpoint
     configuration:
-      secret: !env MY_OTHER_SECRET
+      username: my_username
+      password: !env WEBHOOK_PASSWORD
     events:
       - pr:modified
diff --git a/src/bec_webhook_t.erl b/src/bec_webhook_t.erl
@@ -18,7 +18,10 @@
                     , createdDate   => pos_integer()
                     , updatedDate   => pos_integer()
                     , active        := boolean()
-                    , configuration := #{ secret := binary() }
+                    , configuration := #{ secret := binary()
+                                        , username := binary()
+                                        , password := binary()
+                                        }
                     , events        := [binary()]
                     , name          := binary()
                     , url           := binary()

diff --git a/test/bec_proper_gen.erl b/test/bec_proper_gen.erl
@@ -310,10 +310,19 @@ webhook_active() ->
 webhook_secret() ->
   non_empty(string_b()).
 
+webhook_username() ->
+  non_empty(string_b()).
+
+webhook_password() ->
+  non_empty(string_b()).
+
 webhook_config() ->
-  ?LET( Secret
-      , webhook_secret()
-      , #{ secret => Secret }).
+  ?LET({Secret, Username, Password}
+      , {webhook_secret(), webhook_username(), webhook_password()}
+      , #{ secret => Secret
+        , username => Username
+        , password => Password
+        }).
 
 webhook_event() ->
   oneof([<<"pr:modified">>, <<"repo:refs_changed">>]).