Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd decode: Use compound decSymbol #144

Merged
merged 3 commits into from
Aug 3, 2019
Merged

zstd decode: Use compound decSymbol #144

merged 3 commits into from
Aug 3, 2019

Commits on Jul 28, 2019

  1. zstd decode: Use compound decSymbol 

    The compiler is not generating very nice code when decSymbol is separate values.

Use a compound value instead of a struct.

```
name                                     old time/op    new time/op    delta
Decoder_DecodeAll/kppkn.gtb.zst-12          610µs ± 1%     599µs ± 1%  -1.84%        (p=0.000 n=10+10)
Decoder_DecodeAll/geo.protodata.zst-12      138µs ± 2%     136µs ± 0%  -1.72%         (p=0.000 n=10+9)
Decoder_DecodeAll/plrabn12.txt.zst-12      1.95ms ± 1%    1.90ms ± 0%  -2.19%         (p=0.000 n=10+7)
Decoder_DecodeAll/lcet10.txt.zst-12        1.46ms ± 2%    1.42ms ± 1%  -2.48%        (p=0.000 n=10+10)
Decoder_DecodeAll/asyoulik.txt.zst-12       506µs ± 1%     497µs ± 1%  -1.83%         (p=0.000 n=10+9)
Decoder_DecodeAll/alice29.txt.zst-12        655µs ± 1%     636µs ± 1%  -2.97%        (p=0.000 n=10+10)
Decoder_DecodeAll/html_x_4.zst-12           267µs ± 1%     261µs ± 1%  -2.43%         (p=0.000 n=10+9)
Decoder_DecodeAll/paper-100k.pdf.zst-12    25.0µs ± 1%    24.3µs ± 1%  -2.61%        (p=0.000 n=10+10)
Decoder_DecodeAll/fireworks.jpeg.zst-12    9.65µs ± 1%    9.61µs ± 0%    ~            (p=0.250 n=10+9)
Decoder_DecodeAll/urls.10K.zst-12          1.67ms ± 1%    1.63ms ± 2%  -2.29%        (p=0.000 n=10+10)
Decoder_DecodeAll/html.zst-12               156µs ± 1%     155µs ± 1%  -0.85%        (p=0.014 n=10+10)

name                                     old speed      new speed      delta
Decoder_DecodeAll/kppkn.gtb.zst-12        302MB/s ± 1%   308MB/s ± 1%  +1.88%        (p=0.000 n=10+10)
Decoder_DecodeAll/geo.protodata.zst-12    860MB/s ± 2%   875MB/s ± 0%  +1.75%         (p=0.000 n=10+9)
Decoder_DecodeAll/plrabn12.txt.zst-12     248MB/s ± 1%   253MB/s ± 0%  +2.24%         (p=0.000 n=10+7)
Decoder_DecodeAll/lcet10.txt.zst-12       293MB/s ± 2%   300MB/s ± 1%  +2.54%        (p=0.000 n=10+10)
Decoder_DecodeAll/asyoulik.txt.zst-12     247MB/s ± 1%   252MB/s ± 1%  +1.86%         (p=0.000 n=10+9)
Decoder_DecodeAll/alice29.txt.zst-12      232MB/s ± 1%   239MB/s ± 1%  +3.06%        (p=0.000 n=10+10)
Decoder_DecodeAll/html_x_4.zst-12        1.53GB/s ± 1%  1.57GB/s ± 1%  +2.49%         (p=0.000 n=10+9)
Decoder_DecodeAll/paper-100k.pdf.zst-12  4.10GB/s ± 1%  4.21GB/s ± 1%  +2.68%        (p=0.000 n=10+10)
Decoder_DecodeAll/fireworks.jpeg.zst-12  12.8GB/s ± 1%  12.8GB/s ± 0%    ~            (p=0.286 n=10+9)
Decoder_DecodeAll/urls.10K.zst-12         420MB/s ± 1%   430MB/s ± 2%  +2.35%        (p=0.000 n=10+10)
Decoder_DecodeAll/html.zst-12             655MB/s ± 1%   661MB/s ± 1%  +0.86%        (p=0.015 n=10+10)
```
    @klauspost
    klauspost committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    fce36df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into zstd-compund-decSymbol

    @klauspost
    klauspost committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    a1c5fff View commit details
    Browse the repository at this point in the history

  3. Remove total bit check.

    @klauspost
    klauspost committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    aef707b View commit details
    Browse the repository at this point in the history