Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

fix use of *reflect.SliceHeader #1313

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

aidan-kwon
Copy link
Member

Proposed changes

go vet warns the current use of *reflect.SliceHeader.
The code is changed in more recommended way.

consensus/gxhash/algorithm.go:146:12: possible misuse of reflect.SliceHeader
consensus/gxhash/algorithm.go:149:37: possible misuse of reflect.SliceHeader
consensus/gxhash/algorithm.go:287:12: possible misuse of reflect.SliceHeader
consensus/gxhash/algorithm.go:290:39: possible misuse of reflect.SliceHeader
consensus/gxhash/gxhash.go:106:12: possible misuse of reflect.SliceHeader
consensus/gxhash/gxhash.go:110:42: possible misuse of reflect.SliceHeader

The rationale of this change: golang/go#40701

All changes in this PR are imported from ethereum/go-ethereum#21372 ethereum/go-ethereum#22696

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@kjhman21 kjhman21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. those are not used in our production, though. :)

@aidan-kwon aidan-kwon merged commit ba5e767 into klaytn:dev Apr 11, 2022
@aidan-kwon aidan-kwon deleted the 220408-vetReflect branch April 11, 2022 01:12
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants