New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling : Remove side effects #403

Open

Hartorn opened this issue Aug 17, 2017 · 0 comments

Labels

Bug

Contributor

Hartorn commented Aug 17, 2017

Currently, if you give an object in entry to the error handling method (errorOnCall, etc), this object is undergoing side effects.

It should not, a copy should be done and returned.
It is particularly bad in case of unit testing, where we have to do {...obj} to avoid side effects

Hartorn added the Bug label

Hartorn assigned c3dr0x, Hartorn and JohnnP

AdrienViala unassigned c3dr0x, Hartorn and JohnnP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment