CX SQL_Injection @ riches/WEB-INF/src/java/com/fortify/samples/riches/Messages.java [master]

[kmcdon83]

SQL_Injection issue exists @ riches/WEB-INF/src/java/com/fortify/samples/riches/Messages.java in branch master

The application's getMessage method executes an SQL query with createQuery, at line 132 of riches\WEB-INF\src\java\com\fortify\samples\riches\model\MessageService.java. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
The attacker would be able to inject arbitrary data into the SQL query, by simply altering the user input getRemoteUser, which is read by the execute method at line 18 of riches\WEB-INF\src\java\com\fortify\samples\riches\Messages.java. This input then flows through the code to the database server, without sanitization.
This may enable an SQL Injection attack.

Severity: High

CWE:89

Vulnerability details and guidance

Internal Guidance

Checkmarx

Lines: 20

---

Code (Line #20):

        messages = MessageService.getMessage(ServletActionContext.getRequest().getRemoteUser());

---

[kmcdon83]

Issue still exists.