From a0f67c725d395a7aa51bb58d7ed9bcdd265df1bf Mon Sep 17 00:00:00 2001
From: Gelo <chrisgelosulit@gmail.com>
Date: Fri, 29 Sep 2023 16:32:46 +0800
Subject: [PATCH] Update propelauth_user_id with propelauthUser.userId if
 propelauthUser exists

---
 src/users/services/cron/user-update.cron.service.ts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/users/services/cron/user-update.cron.service.ts b/src/users/services/cron/user-update.cron.service.ts
index 22ba2af..0954ff5 100644
--- a/src/users/services/cron/user-update.cron.service.ts
+++ b/src/users/services/cron/user-update.cron.service.ts
@@ -40,7 +40,7 @@ export class UserUpdateCronService {
           u.email,
         );
 
-        if (userInErpHrV1.status === 200) {
+        if (userInErpHrV1.status === 200 && propelauthUser) {
           const {
             sr,
             name,
@@ -55,7 +55,7 @@ export class UserUpdateCronService {
           const updatedUser = await this.pgsql
             .updateTable('users')
             .set({
-              propelauth_user_id: propelauthUser ? propelauthUser.userId : null,
+              propelauth_user_id: propelauthUser.userId,
               employee_id: sr || 'Not set in erp hr',
               full_name: name,
               first_name: firstName,
@@ -67,6 +67,7 @@ export class UserUpdateCronService {
                   ? TEMPORARY_APPROVER
                   : hrbpEmail,
               position,
+              temporary_propelauth_user_id: false,
               updated_via_cron_erp_hr: true,
             })
             .returning(['users.email'])