fix: triggerv2 supports cg id templates

Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-extensions · Apr 3, 2024 · 8b07dc2 · 8b07dc2
1 parent d12c18f
commit 8b07dc2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/control-plane/pkg/reconciler/trigger/v2/controllerv2.go b/control-plane/pkg/reconciler/trigger/v2/controllerv2.go
@@ -107,6 +107,14 @@ func NewController(ctx context.Context, watcher configmap.Watcher, configs *conf
 		}
 	})
 
+	kafkaFeatureStore := apisconfig.NewStore(ctx, func(_ string, value *apisconfig.KafkaFeatureFlags) {
+		reconciler.KafkaFeatureFlags.Reset(value)
+		if globalResync != nil {
+			globalResync()
+		}
+	})
+	kafkaFeatureStore.WatchConfigs(watcher)
+
 	globalResync = func() {
 		impl.FilteredGlobalResync(filterTriggers(reconciler.BrokerLister), triggerInformer.Informer())
 	}

diff --git a/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go b/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go
@@ -48,6 +48,10 @@ func TestNewController(t *testing.T) {
 		ObjectMeta: metav1.ObjectMeta{
 			Name: "config-features",
 		},
+	}, &corev1.ConfigMap{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "config-kafka-features",
+		},
 	}), &config.Env{})
 	if controller == nil {
 		t.Error("failed to create controller: <nil>")