Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Remove limit on the number of triggers per broker #337

Closed
lionelvillard opened this issue Oct 23, 2020 · 10 comments
Closed

[Broker] Remove limit on the number of triggers per broker #337

lionelvillard opened this issue Oct 23, 2020 · 10 comments
Assignees
Labels
area/control-plane area/data-plane kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lionelvillard
Copy link
Contributor

Problem
The broker controller seems to create a ConfigMap containing all trigger configurations, putting a hard limit on how many triggers can be handled by a single broker.

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

This is more a question than a feature request. Feel free to close if I misunderstood how it works.

@pierDipi
Copy link
Member

Yes, I've thought about this for a while now.

/assign

cc @slinkydeveloper

@pierDipi
Copy link
Member

/area data-plane
/area control-plane

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2021
@pierDipi
Copy link
Member

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2021
@pierDipi pierDipi added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2021
@slinkydeveloper
Copy link
Contributor

I do wonder, @pierDipi and @lionelvillard, do we have an estimate on how large that number is?

@pierDipi
Copy link
Member

No that I'm aware of, I can find an upper bound in extreme situations.

@pierDipi
Copy link
Member

N = 1200, the contract in json is almost 1MB

n 1200 json 987166 proto 793789

N = 1500, the contract in proto is almost 1MB

n 1500 json 1233766 proto 992089

https://gist.github.com/pierDipi/f2d6775c68d4c6b44b6fbfb6e73050e3

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Jun 1, 2021

@pierDipi thanks for the numbers! @lionelvillard what kind of "numbers" your kafka source operates with usually?

@pierDipi
Copy link
Member

Fixed by #3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane area/data-plane kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants