You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the loading of the OIDC config from the discovery endpoint is not very robust and fails on an invalid OIDC config (e.g. when the issuer was configured in the k8s config without https and thus the query results in a 404):
logger.error("Failed to parse OIDC discovery info", e);
returnFuture.failedFuture(e);
}
})
.compose(res -> {
This should be changed (e.g. status code checking) and the OIDCDiscoveryConfig fail the returned future correctly in such a case (e.g. with an additional exception, which can then be handled by the caller).
The text was updated successfully, but these errors were encountered:
creydr
changed the title
Make OIDCDiscoveryConfig more resistant against invalid OIDC discovery config
[data-plane]: Make OIDCDiscoveryConfig more resistant against invalid OIDC discovery config
Feb 6, 2024
Currently the loading of the OIDC config from the discovery endpoint is not very robust and fails on an invalid OIDC config (e.g. when the issuer was configured in the k8s config without https and thus the query results in a 404):
eventing-kafka-broker/data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/oidc/OIDCDiscoveryConfig.java
Lines 60 to 84 in 02be94e
This should be changed (e.g. status code checking) and the OIDCDiscoveryConfig fail the returned future correctly in such a case (e.g. with an additional exception, which can then be handled by the caller).
The text was updated successfully, but these errors were encountered: