Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create paired pre-upgrade and post-upgrade tests which create resources before upgrade and verify them after upgrade #4047

Open
mgencur opened this issue Aug 8, 2024 · 2 comments · May be fixed by #4095
Labels
area/test kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@mgencur
Copy link
Contributor

mgencur commented Aug 8, 2024

This is currently not the case because the pre-upgrade tests create its own set of resources and verify them, and post-upgrade tests create yet another set of resources and verify them. The resources from pre-upgrades do NOT live through the upgrades.

Problem

The only set of tests which create resources before upgrade and verify them later are the "continual" upgrade tests. The problem is that the test suite performs "downgrades" right after upgrades, so potential problems like #4034 are not caught because the problem is "fixed" again after downgrades.

The new upgrade tests should be added to the existing ones.
They should follow this scenario:

  • Create resources before upgrade
  • Perform upgrade
  • Verify the existing resources after upgrade
  • Delete the resources (either directly or by deleting the test namespace)
  • Create a new set of resources
  • Perform downgrade
  • Verify the existing resources after downgrade
  • Delete the resources (either directly or by deleting the test namespace)

Persona:
Developers/Testers

Exit Criteria
Upgrade/downgrade tests working.

Time Estimate (optional):
2-3

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Aug 12, 2024
@Cali0707
Copy link
Member

/area test

@mgencur mgencur changed the title Create paired pre-upgrade and post-upgrade tests which create resources before upgrade and verify them after ugprade Create paired pre-upgrade and post-upgrade tests which create resources before upgrade and verify them after upgrade Aug 21, 2024
@mgencur mgencur linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants