Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The update-gofmt action tries to reformat code in vendor directory, in multi-module projects #259

Closed
cardil opened this issue Feb 1, 2023 · 1 comment
Closed

The update-gofmt action tries to reformat code in vendor directory, in multi-module projects #259

cardil opened this issue Feb 1, 2023 · 1 comment
Assignees
@cardil @sbdtu5498
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Feb 1, 2023

The code below will try to reformat code in a vendor dir, for projects that uses Go workspaces, which is invalid.

https://github.com/knative-sandbox/knobots/blob/026ea75761265a6a7a6f0b93b7f8dd1e615f3953/actions/update-gofmt/entrypoint.sh#L27-L36

An example of faulty PR can be seen here: knative-extensions/kn-plugin-event#263

/kind bug
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2023
@cardil cardil mentioned this issue Feb 1, 2023
Closed
@cardil cardil self-assigned this Feb 1, 2023
@cardil cardil mentioned this issue Mar 14, 2023
Open
17 tasks
@sbdtu5498
Copy link
Contributor

/assign

@sbdtu5498 sbdtu5498 mentioned this issue Jun 27, 2023
Merged
@krsna-m krsna-m closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cardil cardil

@sbdtu5498 sbdtu5498

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cardil @krsna-m @sbdtu5498