Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --inject-broker flag from trigger cmds #1846

Closed
dsimansk opened this issue Aug 10, 2023 · 1 comment · Fixed by #1853
Closed

Remove deprecated --inject-broker flag from trigger cmds #1846

dsimansk opened this issue Aug 10, 2023 · 1 comment · Fixed by #1853
Assignees
@xiangpingjiang
Labels
good first issue Denotes an issue ready for a new contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Knative 1.12

Comments

@dsimansk
Copy link
Contributor

dsimansk commented Aug 10, 2023 •
edited
Loading

Per title and code comment remove the deprecated code.

client/pkg/kn/commands/trigger/update_flags.go

Lines 54 to 60 in 8dc8a9f

// The Sugar controller was integrated into main Eventing controller. With that the default behavior was changed as well.
// Users need to configure 'Automatic Broker Creation' per linked docs.
// Deprecated in 1.4, remove in 1.6.
cmd.Flags().BoolVar(&f.InjectBroker, "inject-broker", false, "Create new broker with name default through common annotation")
cmd.Flags().MarkDeprecated("inject-broker", "effective since 1.4 and will be removed in 1.6 release. \n"+
"Please refer to 'Automatic Broker Creation' section for configuration options, "+
"https://knative.dev/docs/eventing/sugar/#automatic-broker-creation.")

@dsimansk dsimansk added this to the Knative 1.12 milestone Aug 10, 2023
@dsimansk dsimansk added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Denotes an issue ready for a new contributor. labels Aug 10, 2023
@xiangpingjiang
Copy link
Contributor

/assign

@xiangpingjiang xiangpingjiang mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpingjiang xiangpingjiang

Labels
good first issue Denotes an issue ready for a new contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Client Planning
Status: Done
Milestone
Knative 1.12
Development

Successfully merging a pull request may close this issue.

Remove deprecated --inject-broker flag from trigger cmds xiangpingjiang/client
2 participants
@dsimansk @xiangpingjiang