-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified channel flag to align with sink flag parsing #1951
base: main
Are you sure you want to change the base?
Conversation
Welcome @EraKin575! It looks like this is your first PR to knative/client 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EraKin575 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @EraKin575. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EraKin575: 0 warnings.
In response to this:
Description
Refactor the ChannelRef structure's Parse method to utilize the common implementation for parsing GVK formats.
Changes
*modified channel flag parsing to align with sink flag
*
*Reference
Fixes #1871
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
- Coverage 76.82% 76.81% -0.02%
==========================================
Files 207 207
Lines 12892 12895 +3
==========================================
+ Hits 9904 9905 +1
- Misses 2187 2188 +1
- Partials 801 802 +1 ☔ View full report in Codecov by Sentry. |
@EraKin575 thanks for the contribution and looking into the issue. My idea from #1871 to align https://github.com/knative/client/blob/main/pkg/kn/commands/flags/sink.go |
make it a common function for both sink and channel flags, right? |
Yes, exactly that. |
Description
Refactor the ChannelRef structure's Parse method to utilize the common implementation for parsing GVK formats.
Changes
*modified channel flag parsing to align with sink flag
*
*
Reference
Fixes #1871
Release Note