Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Codespaces for Knative? #1295

Closed
psschwei opened this issue Feb 27, 2023 · 8 comments
Closed

Enable Codespaces for Knative? #1295

psschwei opened this issue Feb 27, 2023 · 8 comments
Assignees

Comments

@psschwei
Copy link
Contributor

Via the CNCF, there's an offer from Github to help set up and enable Codespaces for Knative, so creating an issue for us to discuss. Not sure if this falls under TOC or Steering, but for now will add it to the TOC board...

@psschwei
Copy link
Contributor Author

cc @knative/technical-oversight-committee @knative/steering-committee

@evankanderson
Copy link
Member

Dave would better like to understand what this means, since you can use Codespaces on the fork.

@evankanderson
Copy link
Member

@dprotaso @kvmware @upodroid have been meeting with a GitHub TPM, will follow up on this.

@evankanderson
Copy link
Member

/assign @dprotaso

@dprotaso dprotaso moved this from Needs discussion to In Progress in Technical Oversight Backlog Mar 9, 2023
@dprotaso
Copy link
Member

dprotaso commented Mar 21, 2023

Contact has been made here - knative/serving#13806

tl;dr we will run an experiment and use the GSoC users as a test cohort.

@dprotaso
Copy link
Member

Following up - the experience of using Codespaces in Serving is poor when using the default prow image that has all the tools installed. Start times are slow. A way to mitigate that is to use prebuilt codespaces - but this can't be leveraged by non-Knative members since this requires opening the codespace in the knative org which is a non-starter.

Based on this I don't recommend a project wide initiative to continue this further. Though I won't object if subgroups choose to try it themselves.

I'll leave the Serving issue open in case someone volunteers to try to improve what's been there but overall.

I'm going to close this out.

@craiglpeters
Copy link

I think that prebuilding a container with the prow image as your base image will do the trick. https://containers.dev/guide/prebuild Reach out in Kubernetes Slack to craiglpeters if I can be of help

@Cali0707
Copy link
Member

Cali0707 commented Nov 9, 2023

Cc @r2-lf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants