Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Implement tracing for KafkaChannel #1139

Closed
slinkydeveloper opened this issue Apr 15, 2020 · 0 comments · Fixed by #1155
Closed

Implement tracing for KafkaChannel #1139

slinkydeveloper opened this issue Apr 15, 2020 · 0 comments · Fixed by #1155
Assignees
@slinkydeveloper
Labels
area/kafka area/observability channel/kafka Kafka channel related issue kind/feature-request

Comments

@slinkydeveloper
Copy link
Contributor

Problem
KafkaChannel tracing support

Persona:
Event Consumer/Producer

Exit Criteria
KafkaChannel should pass E2E tracing tests as IMC channel

Additional context (optional)
Now that MessageDispatcher correctly handles traces, we just need to setup the traceparent injection/extraction when we push the message in Kafka and when we read back the message from Kafka. This can be done easily with new additions to sdk-go, in particular DistributedTracingExtension.ReadTransformer() and DistributedTracingExtension.WriteTransformer()

/assign
/cc @ian-mi
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@slinkydeveloper slinkydeveloper

Labels
area/kafka area/observability channel/kafka Kafka channel related issue kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

KafkaChannel Tracing slinkydeveloper/eventing-contrib
3 participants
@grantr @lionelvillard @slinkydeveloper