From 0917cb0eb945b037b206a1fa6540ef3725ff448a Mon Sep 17 00:00:00 2001
From: Rahul-Kumar-prog <rahulkumarrsde@gmail.com>
Date: Tue, 28 May 2024 19:16:36 +0530
Subject: [PATCH] Change trigger requirement phases

---
 test/rekt/features/trigger/feature.go | 49 +++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/test/rekt/features/trigger/feature.go b/test/rekt/features/trigger/feature.go
index 219e48535ce..684cc7350fc 100644
--- a/test/rekt/features/trigger/feature.go
+++ b/test/rekt/features/trigger/feature.go
@@ -126,7 +126,22 @@ func TriggerWithTLSSubscriber() *feature.Feature {
 		trigger.Install(triggerName, brokerName,
 			trigger.WithSubscriberFromDestination(subscriber))(ctx, t)
 	})
-	f.Setup("Wait for Trigger to become ready", trigger.IsReady(triggerName))
+
+	f.Requirement("Wait for Trigger to become ready", trigger.IsReady(triggerName))
+
+	f.Setup("trigger is not ready", func(ctx context.Context, t feature.T) {
+		trigger, err := trigger.Get(ctx, triggerName)
+		if err != nil {
+			t.Fatalf("Failed to get Trigger: %v", err)
+		}
+		if trigger.Status.IsReady() {
+			t.Fatalf("Trigger is ready when it should not be")
+		}
+		reason := trigger.Status.GetCondition(apis.ConditionReady).reason
+		if reason != "DependencyDoesNotExist" {
+			t.Fatalf("expected reason to be DependencyDoesNotExist but got: %v", reason)
+		}
+	})
 
 	f.Setup("Install failing trigger", func(ctx context.Context, t feature.T) {
 		dls := service.AsDestinationRef(dlsName)
@@ -138,6 +153,21 @@ func TriggerWithTLSSubscriber() *feature.Feature {
 			trigger.WithDeadLetterSinkFromDestination(dls),
 			trigger.WithSubscriber(nil, "http://127.0.0.1:2468"))(ctx, t)
 	})
+	f.Requirement("Wait for failing Trigger to become ready", trigger.IsReady(dlsTriggerName))
+
+	f.Setup("Failed trigger is not ready", func(ctx context.Context, t feature.T) {
+		trigger, err := trigger.Get(ctx, dlsTriggerName)
+		if err != nil {
+			t.Fatalf("Failed to get Trigger: %v", err)
+		}
+		if trigger.Status.IsReady() {
+			t.Fatalf("Failed Trigger is ready when it should not be")
+		}
+		reason := trigger.Status.GetCondition(apis.ConditionReady).reason
+		if reason != "DependencyDoesNotExist" {
+			t.Fatalf("expected reason to be DependencyDoesNotExist but got: %v", reason)
+		}
+	})
 	f.Setup("Wait for failing Trigger to become ready", trigger.IsReady(dlsTriggerName))
 
 	// Install Source
@@ -199,7 +229,22 @@ func TriggerWithTLSSubscriberTrustBundle() *feature.Feature {
 		trigger.Install(triggerName, brokerName,
 			trigger.WithSubscriberFromDestination(subscriber))(ctx, t)
 	})
-	f.Setup("Wait for Trigger to become ready", trigger.IsReady(triggerName))
+
+	f.Requirement("Wait for failing Trigger to become ready", trigger.IsReady(triggerName))
+
+	f.Setup("Failed trigger is not ready", func(ctx context.Context, t feature.T) {
+		trigger, err := trigger.Get(ctx, triggerName)
+		if err != nil {
+			t.Fatalf("Failed to get Trigger: %v", err)
+		}
+		if trigger.Status.IsReady() {
+			t.Fatalf("Failed Trigger is ready when it should not be")
+		}
+		reason := trigger.Status.GetCondition(apis.ConditionReady).reason
+		if reason != "DependencyDoesNotExist" {
+			t.Fatalf("expected reason to be DependencyDoesNotExist but got: %v", reason)
+		}
+	})
 
 	f.Setup("Install failing trigger", func(ctx context.Context, t feature.T) {
 		dls := &duckv1.Destination{