From 746dc52c1a2fb3b152dad71d62e60c09d8a3fa9f Mon Sep 17 00:00:00 2001 From: Calum Murray Date: Wed, 29 May 2024 02:23:36 -0400 Subject: [PATCH] fix: no more panic in the execute request method (#7947) Signed-off-by: Calum Murray --- pkg/kncloudevents/event_dispatcher.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/kncloudevents/event_dispatcher.go b/pkg/kncloudevents/event_dispatcher.go index 877a2067575..a9c3bd5cd45 100644 --- a/pkg/kncloudevents/event_dispatcher.go +++ b/pkg/kncloudevents/event_dispatcher.go @@ -289,11 +289,18 @@ func (d *Dispatcher) send(ctx context.Context, message binding.Message, destinat } func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressable, message cloudevents.Message, additionalHeaders http.Header, retryConfig *RetryConfig, oidcServiceAccount *types.NamespacedName, transformers ...binding.Transformer) (context.Context, cloudevents.Message, *DispatchInfo, error) { + var scheme string + if target.URL != nil { + scheme = target.URL.Scheme + } else { + // assume that the scheme is http by default + scheme = "http" + } dispatchInfo := DispatchInfo{ Duration: NoDuration, ResponseCode: NoResponse, ResponseHeader: make(http.Header), - Scheme: target.URL.Scheme, + Scheme: scheme, } ctx, span := trace.StartSpan(ctx, "knative.dev", trace.WithSpanKind(trace.SpanKindClient))