Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use global scheme in tests #596

Closed
grantr opened this issue Nov 8, 2018 · 1 comment
Closed

Don't use global scheme in tests #596

grantr opened this issue Nov 8, 2018 · 1 comment
Assignees
@grantr

Comments

@grantr
Copy link
Contributor

grantr commented Nov 8, 2018

Tests that use the package-level scheme.Scheme variable may be vulnerable to interference from other tests that add types to it (TODO confirm this is true).

Blocked by kubernetes-sigs/controller-runtime#137.
@mikehelmick
Copy link
Contributor

/assign @grantr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grantr grantr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grantr @mikehelmick @paulrossman