Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create client for EventPolicy #7988

Closed
creydr opened this issue Jun 11, 2024 · 1 comment
Closed

Create client for EventPolicy #7988

creydr opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Jun 11, 2024

To work with the EventPolicy type (#7971), we need to add a new client. This should be doable by adding

// +genclient

to the EventPolicy type and running ./hack/update-codegen.sh.

Prerequisites:

Additional Information:

  • Check for example on the Broker type, how the client was added

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign) and ask any question you have. Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 11, 2024
@creydr
Copy link
Member Author

creydr commented Jun 11, 2024

Closing this as we included this in #7971

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants