Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mt-broker-filter: Allow only requests from Subscriptions OIDC ID #7989

Closed
creydr opened this issue Jun 11, 2024 · 12 comments · Fixed by #8147
Closed

mt-broker-filter: Allow only requests from Subscriptions OIDC ID #7989

creydr opened this issue Jun 11, 2024 · 12 comments · Fixed by #8147
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 11, 2024

We need to verify in the mt-broker-filter, that an request comes only from the Subscriptions OIDC is (.status.auth.serviceAccountName). Therefor we should do the following in the mt-broker-filter handler:

  • In case OIDC is enabled:
    • Get the OIDC identity of the sender
    • check, if the senders identity is the same as the according Subscriptions OIDC ID (in their .status.auth.serviceAccountName).
      • If it matches: continue with the request
      • If not: reject the request with a 403 status code
  • In OIDC is disabled:
    • no change in behaviour

Prerequisites:

Additional context:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr creydr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage) labels Jun 11, 2024
@babugeet
Copy link
Contributor

I would like to work on this
/assign

@ayushrakesh
Copy link

/assign

@creydr
Copy link
Member Author

creydr commented Jun 27, 2024

Hey @ayushrakesh,
thanks for showing interest in this issue. But this issue is currently assigned to @babugeet.
@babugeet are you still planing to work on this issue?

@babugeet
Copy link
Contributor

@creydr : got caught up in some other work, let @ayushrakesh : proceed with the changes

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 9, 2024

Hello @ayushrakesh, are there anything I can help you with regarding this issue?

@rahulii
Copy link
Contributor

rahulii commented Jul 13, 2024

Hello @ayushrakesh are you still planning to work on the issue?

@EraKin575
Copy link
Contributor

I can work on this if @ayushrakesh is not working on this

@ayushrakesh
Copy link

@EraKin575 Sorry for delay, you can work on that.

@EraKin575
Copy link
Contributor

/assign

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 22, 2024

Are there anything I could help you with? @EraKin575

If you're still working on this issue, please let me know within the next 24 hours. We understand that plans and priorities can change, and if you're no longer able to continue with this task, that's completely okay! In case I don't hear back from you in the next 24 hours, I'll unassign the issue from you. Of course, if you'd like to continue working on it later, you can always reassign it to yourself if it is still available.

@EraKin575
Copy link
Contributor

Sorry,for the delay. I am still working on this issue and will raise a PR ASAP

@EraKin575
Copy link
Contributor

sorry, this took a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
6 participants