Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rekt tests for DefaultBrokerClass config #8021

Open
2 tasks
Leo6Leo opened this issue Jun 21, 2024 · 0 comments
Open
2 tasks

Add rekt tests for DefaultBrokerClass config #8021

Leo6Leo opened this issue Jun 21, 2024 · 0 comments
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Leo6Leo
Copy link
Member

Leo6Leo commented Jun 21, 2024

Problem
We need to add rekt (reconciler tests) for the DefaultBrokerClass configuration. The focus should be on validating that the default configuration works correctly with the recent changes.

Persona
Eventing Contributor

Exit Criteria

  • Rekt tests for DefaultBrokerClass configuration are implemented
  • Tests pass, confirming that the default configuration works as expected with new changes

Scope

  • This test should focus on the default configuration
  • Extensive corner cases are not required, as they will be covered by unit tests

Time Estimate
1 developer-day

Dependencies

Additional Context

  • The rekt tests implemented here should be focused and not cover many different corner cases, as those will be handled by unit tests to avoid expensive rekt tests.
  • Once PR Broker class based defaults #7631 is merged, this task will be unblocked and ready for implementation.
@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants