Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook for EventPolicy #7972

Closed
creydr opened this issue Jun 10, 2024 · 7 comments · Fixed by #8091
Closed

Add webhook for EventPolicy #7972

creydr opened this issue Jun 10, 2024 · 7 comments · Fixed by #8091
Assignees
@dharmjit
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 10, 2024 •
edited
Loading

We need to add a webhook for EventPolicies, with at least the following validations for EventPolicies:

  • An EventPolicy must not be created, when the authentication-oidc feature flag is disabled
  • EventPolicySpecTo must only contain either a Ref or a Selector. Not both at the same time

Prerequisites:

Additional context:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
  5. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 10, 2024
@pierDipi
Copy link
Member

pierDipi commented Jun 12, 2024 •
edited
Loading

EventPolicySpecTo must only contain either a Ref or a Selector. Not both at the same time

I did (perhaps wrongly) include this validation logic in this PR: #7995

@dharmjit
Copy link
Contributor

Hi @creydr @pierDipi , If okay, I can take this up.

@creydr
Copy link
Member Author

creydr commented Jun 12, 2024

Hey @dharmjit,
would be great, if you could work on this. The other required issue (#7974) should be done soon the the PR merge (I just lgtm'ed it).

/assign @dharmjit

@creydr creydr added the triage/accepted Issues which should be fixed (post-triage) label Jun 13, 2024
@creydr
Copy link
Member Author

creydr commented Jun 18, 2024

Hey @dharmjit,
as the prerequisite issues are resolved, this should be ready to be worked on (moved from "Backlog" to "Ready").

@rahulii
Copy link
Contributor

rahulii commented Jun 18, 2024

Hey @dharmjit , let me know if you don't have sufficient bandwidth so that I can take this up while you are working on the reconciler part (which itself is a big part)
Thanks!

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 9, 2024

@dharmjit are there anything I can help you with?

If you're still working on this issue, please let me know within the next 24 hours. We understand that plans and priorities can change, and if you're no longer able to continue with this task, that's completely okay! In case I don't hear back from you in the next 24 hours, I'll reassign the issue to @rahulii to ensure our workflow continues smoothly.

@dharmjit
Copy link
Contributor

dharmjit commented Jul 9, 2024

@Leo6Leo Apologies, I got caught up in some stuff. I will try to pick this up tomorrow and submit a PR.

@dharmjit dharmjit mentioned this issue Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dharmjit dharmjit

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Authorization
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added EventPolicy Webhook dharmjit/eventing
5 participants
@dharmjit @creydr @rahulii @pierDipi @Leo6Leo