Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for InMemoryChannel authorization #8142

Closed
creydr opened this issue Aug 9, 2024 · 4 comments · Fixed by #8162
Closed

Add e2e test for InMemoryChannel authorization #8142

creydr opened this issue Aug 9, 2024 · 4 comments · Fixed by #8162
Assignees
@rahulii
Labels
area/test-and-release Test infrastructure, tests or release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Aug 9, 2024 •
edited
Loading

Add an e2e test to test the authorization feature for the InMemoryChannel:

  • allow authorized requests
  • reject unauthorized requests

Requires #7981

It would be good if this test would be held generic, that other channel implementations could easily reuse this

You can check on #8132 how this was done for the Broker.
@creydr creydr added area/test-and-release Test infrastructure, tests or release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage) labels Aug 9, 2024
@rahulii
Copy link
Contributor

rahulii commented Aug 9, 2024

/assign

@creydr
Copy link
Member Author

creydr commented Aug 12, 2024

@rahulii I am planning to add some "conformance suite" for the AuthZ part in #8149. This should make the integration here easier.

@rahulii
Copy link
Contributor

rahulii commented Aug 12, 2024

Sure, that would help.
I am waiting for #7981 to be done!

@creydr
Copy link
Member Author

creydr commented Aug 16, 2024

Hi @rahulii,
I think this was done as part of #8162

@creydr creydr closed this as completed Aug 16, 2024
@creydr creydr linked a pull request Sep 2, 2024 that will close this issue
Support authorization in Channel ingress #8162
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulii rahulii

Labels
area/test-and-release Test infrastructure, tests or release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Authorization
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support authorization in Channel ingress creydr/knative-eventing
2 participants
@creydr @rahulii