Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit shellcheck to diff-context for hack repo #207

Closed
krsna-m opened this issue Sep 25, 2023 · 0 comments
Closed

Limit shellcheck to diff-context for hack repo #207

krsna-m opened this issue Sep 25, 2023 · 0 comments

Comments

@krsna-m
Copy link
Contributor

krsna-m commented Sep 25, 2023

Shellcheck, which is part of the style action in the actions repo, currently uses the file context which means that it will check for any shell issues across any touched file. Bash/shell is tricky to write and easy to introduce security concerns so this is in place so that it encourages clean up any shell scripts. However, hack has some bloated shell scripts that we will transition away from knative/hack#254. If we use the file context the amount of work needed by engineers is very high to correct the whole file. Therefore the shellcheck style for hack repo should be set to diff-context so that it is more manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant