Add cluster creation logic for local users #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/M
|
Please add tests for the new functions, since they're not placeholders anymore. That helper function for running shell commands will be very useful for covering the scenarios. |
adrcunha
changed the title
knative-prow-robot
added
size/L
|
unit test added, thanks for changing the title btw |
adrcunha
reviewed
Aug 13, 2019
chaodaiG
force-pushed
the
clusterlib_env
branch
from
dec1903 to
4123dde
Compare
adrcunha
reviewed
Aug 13, 2019
chaodaiG
force-pushed
the
clusterlib_env
branch
from
4123dde to
15f3130
Compare
|
/retest
…On Tue, Aug 13, 2019, 4:49 PM Knative Prow Robot ***@***.***> wrote:
@chaodaiG <https://github.com/chaodaiG>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-knative-pkg-unit-tests 15f3130
<15f3130>
link
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_pkg/569/pull-knative-pkg-unit-tests/1161423622468800514> /test
pull-knative-pkg-unit-tests
Full PR test history <https://gubernator.knative.dev/pr/knative_pkg/569>. Your
PR dashboard <https://gubernator.knative.dev/pr/chaodaiG>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#569?email_source=notifications&email_token=AKXNDYM74N2KOEKAOOKIVNLQENB75A5CNFSM4ILHDTV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HJTGA#issuecomment-521050520>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKXNDYIQU4RTULM7SV5Z453QENB75ANCNFSM4ILHDTVQ>
.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, chaodaiG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
ReportObjectsLists now accepts a namespace option to filter results to the test context namespace. This avoids noise from unrelated namespaces in test reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic of checking for local environment, i.e. uses existing cluster if kubeconfig is set, uses existing gcp project if gcloud is set.
Part of: knative/test-infra#1186
/cc @adrcunha