Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: do we want to keep net-certmanager or can we integrate in Serving #14740

Closed
ReToCode opened this issue Dec 20, 2023 · 5 comments · Fixed by #15066
Closed

Discussion: do we want to keep net-certmanager or can we integrate in Serving #14740

ReToCode opened this issue Dec 20, 2023 · 5 comments · Fixed by #15066
Assignees
Milestone

Comments

@ReToCode
Copy link
Member

ReToCode commented Dec 20, 2023

Relates to the discussion in #14720.

Overall, it begs the question if we even need net-certmanager as a separate component and the KnativeCertificate abstraction. When http01 is deprecated and removed, there is only one implementation left.

Arguments

  • Mainly maintainability: we are only three active people maintaining a lot of repos --> just bumping, updating generators and stuff is a lot of work
  • Easier to install and configure:
  • Eventing uses cert-manager directly
  • We can have a separate controller in Serving-controller, only starting when encryption is enabled and cert-manager CRDs are present

@skonto please add more points and link to upcoming Serving WG meeting.

@ReToCode ReToCode converted this from a draft issue Dec 20, 2023
@skonto
Copy link
Contributor

skonto commented Dec 20, 2023

I would add:

  • net-certmanager does not do much, basically it translates Knative certificates to cert-manager certificates. Given that Eventing integrates with cert-manager directly, I think that the right abstraction to integrate is that of a configmap/secret. Most projects out there do the latter. Not sure why Serving needs to do more as long as steps are documented we should be fine.
  • Serving already has several deployments and we should consider simplifying the deployment model.

@dprotaso
Copy link
Member

I think integrating makes sense - let's formalize a plan - cause we'll need a migration path for existing users

@dprotaso
Copy link
Member

Given a migration we might want consider re-working some things - eg. knative-extensions/net-certmanager#353

@dprotaso
Copy link
Member

also related: knative/operator#1621 (comment)

@skonto
Copy link
Contributor

skonto commented Feb 20, 2024

/assign @skonto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment