You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this point (May 15th, 2020), we have switched all Knative projects to use Go modules, but it brings in a regression that makes it impossible to only update vendored scripts from test-infra, when vendored pkg is not at HEAD. More discussions can be found from #2069.
Using multiple Go modules in the test-infra repo can potentially solve this issue, but we need to evaluate carefully to make sure it does not introduce other side effects.
It turned out this approach has some problems, so I reverted the PR in #2185.
The reason is by using this approach, repos which imports the scripts package will get an ambiguous import error as the module can be either knative.dev/test-infra/scripts or knative.dev/test-infra. One solution given in https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository suggests adding knative.dev/test-infra as a required module in knative.dev/test-infra/scripts, but this will defeat our objective to get rid of the circular dependencies in the first place.
We will consider other solutions to solve this issue.
At this point (May 15th, 2020), we have switched all Knative projects to use Go modules, but it brings in a regression that makes it impossible to only update vendored scripts from
test-infra
, when vendoredpkg
is not at HEAD. More discussions can be found from #2069.Using multiple Go modules in the test-infra repo can potentially solve this issue, but we need to evaluate carefully to make sure it does not introduce other side effects.
The doc for multiple modules repository is in https://github.com/golang/go/wiki/Modules#faqs--multi-module-repositories.
/assign
FYI @coryrc @chaodaiG @albertomilan
The text was updated successfully, but these errors were encountered: