Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dotnet packages #1018

Open
husseinraoouf opened this issue Apr 16, 2024 · 4 comments
Open

Support Dotnet packages #1018

husseinraoouf opened this issue Apr 16, 2024 · 4 comments

Comments

@husseinraoouf
Copy link

I wanted to use knope for all packages i publish, i currently publish nodejs, python, and dotnet packages and it doesn't support dotnet, it would be great to add support for dotnet packages, dotnet packages handle [packageName].csproj it is an xml file with structure defined here https://learn.microsoft.com/en-us/aspnet/web-forms/overview/deployment/web-deployment-in-the-enterprise/understanding-the-project-file

for a simple package the file will look like this

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <Authors>Package Author</Authors>
    <Description>Package Description</Description>
    <PackageIcon>icon.png</PackageIcon>
    <PackageLicenseExpression></PackageLicenseExpression>
    <Version>0.0.0</Version>
  </PropertyGroup>
</Project>
@alex-way
Copy link
Contributor

alex-way commented May 7, 2024

Just to double check you just want to be able to increment the version number specified in the [packageName].csproj file?

@husseinraoouf
Copy link
Author

yes excatly

@alex-way
Copy link
Contributor

alex-way commented May 9, 2024

Looks like the answer is to create a module within crates/knope-versioning/src/

e.g. https://github.com/knope-dev/knope/blob/72fb94c104328c1e85c68c056c5ab99bacad5ef6/crates/knope-versioning/src/pyproject.rs

Will investigate further to see if I'm able to assist

@alex-way
Copy link
Contributor

alex-way commented May 9, 2024

Further onto the above, it looks as though there isn't an xml parser. Suggesting we use https://crates.io/crates/serde-xml-rs to be inline with the other parsers in the knope-versioning crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants